Devographics / StateOfJS-2020

Other
103 stars 20 forks source link

Table alternative #48

Closed sarahfossheim closed 2 years ago

sarahfossheim commented 3 years ago

Each visualisation now has two options: graph or table view.

! This relies on a couple of new translations :)

SachaG commented 3 years ago

Looks good to me! I have some ideas to streamline the design a bit, but I think it's a great starting point.

Btw from an accessibility point of view is it easy to discover that the table exists with a screen reader? Because it's not even in the DOM, if I'm not mistaken? Should we have it in the DOM all the time and just hide it with CSS maybe? Or is that not necessary?

Also should I merge this now or wait?

sarahfossheim commented 2 years ago

@SachaG There's a table/viz switch before the table, when picking table it becomes accessible in the dom, so I don't think it's necessary to visually hide it. I can add a reference to it in the alt text / captions for the graphs as well maybe?

Want to fix a few translations first, afterwards good to merge from my end if it looks fine to you.

SachaG commented 2 years ago

OK sounds good then, just let me know when it's ready :)