search

Devolutions / IronRDP

Rust implementation of the Microsoft Remote Desktop Protocol (RDP)
Apache License 2.0
368 stars 48 forks source link

feat(now-proto): initial NOW spec implementation #509

Closed pacmancoder closed 1 month ago

pacmancoder commented 1 month ago

Follow-up to https://github.com/Devolutions/devolutions-gateway/pull/912

No changes in the code except directly using ironrdp-error and ironrdp-pdu

github-actions[bot] commented 1 month ago

Coverage Report :robot: :gear:

Past: Total lines: 30749 Covered lines: 17795 (57.87%)

New: Total lines: 33069 Covered lines: 19376 (58.59%)

Diff: +0.72%

[this comment will be updated automatically]

pacmancoder commented 1 month ago

Respective removal PR in devolutions-gateway https://github.com/Devolutions/devolutions-gateway/pull/941

pacmancoder commented 1 month ago

@CBenoit I updated PR with refactoring commits -- Fixed all issues commented above and fixed all clippy lints after adding workspace-level lints

P.S: Github does not want to pick up this PR for CI runner for some reason right now, can't say for sure if it is mergeable now, I hope CI will pass till tomorrow morning

CBenoit commented 1 month ago

@pacmancoder Great job! The workflow properly ran and ended up green, so I merged it! :rocket: