Closed Tomcat-42 closed 1 year ago
@Tomcat-42 I'll look into getting the secret added for the publishing workflow (our DevOps team is busy this week with our major release, so it may go to next week). Is publishing workflow limited to the master branch? We'd need to add a GitHub environment with the secret in, and restrict how it can be used. Ideally we'd still need to trigger the workflow ourselves, on the master branch only
@Tomcat-42 I'll look into getting the secret added for the publishing workflow (our DevOps team is busy this week with our major release, so it may go to next week). Is publishing workflow limited to the master branch? We'd need to add a GitHub environment with the secret in, and restrict how it can be used. Ideally we'd still need to trigger the workflow ourselves, on the master branch only
The publish job should only run on tagged master now
@Devolutions/devops we'll need an environment with the secret "CARGO_REGISTRY_TOKEN" for the publishing workflow, using the following settings in crates.io:
@Tomcat-42 I'm tagging my @CBenoit - for the publishing workflow, our GitHub organization blocks external GitHub Actions like those used in the current workflow. I know Benoit worked on custom GitHub Actions, but we'd need a bit more time to do this properly with the limitations we have in place. I would suggest splitting the code changes from this pull request so they can be merged quickly, leaving us more time to set up a publishing workflow.
Ok, I Splited the GH Actions into #21
About the BuildDependency::get_include_dirs
changes, it is a trivial one. IMO it can be already merged. Can you make a new release please?
Thank you @Tomcat-42, FYI the new version is now available on crates.io
This pull request:
BuildDependency::get_include_dir
returning just the first include dir (some deps have multiple include dirs). I've renamed the method. Fixes #8 .