search

Devolutions / conan-rs

A Rust wrapper of the conan C/C++ package manager (conan.io) to simplify usage in build scripts
Apache License 2.0
34 stars 11 forks source link

CI: make actions for testing and publishing the crate #21

Open Tomcat-42 opened 8 months ago

Tomcat-42 commented 8 months ago

As pointed by @awakecoding, external actions are blocked by the org. Anyway, I'm pushing this so we can work on refactoring this into a custom GH action.

CBenoit commented 8 months ago

Thank you for that @Tomcat-42!

I think it’s better if we handle the publishing workflow on our side. We already have plans for that, and I’ll apply the workflow to all our open source projects when it’s ready :slightly_smiling_face:

However, I’m open to adding a ci.yml workflow for checking PRs automatically. Ideally, I would like something similar to the one we have on picky-rs:

(with minor adjustments, we don’t have ffi or wasm bindings for conan-rs)

It would be useful to specify the minimal supported Rust version as well, so we can check for it:

In order to easily find the msrv, cargo-msrv can be used.

Maybe the lints step will fail for conan-rs, I don’t know if clippy was ran against much. Enabling this job and fixing the lints should be a separate PR if you decide to go for it

Tomcat-42 commented 8 months ago

I think it’s better if we handle the publishing workflow on our side. We already have plans for that, and I’ll apply the workflow to all our open source projects when it’s ready 🙂

Sure.

However, I’m open to adding a ci.yml workflow for checking PRs automatically. Ideally, I would like something similar to the one we have on picky-rs:

https://github.com/Devolutions/picky-rs/blob/67277e6cc211527aa2bf5da0788f415f2e041409/.github/workflows/ci.yml (with minor adjustments, we don’t have ffi or wasm bindings for conan-rs)

It would be useful to specify the minimal supported Rust version as well, so we can check for it:

https://doc.rust-lang.org/cargo/reference/manifest.html#the-rust-version-field In order to easily find the msrv, cargo-msrv can be used. Yeah, it would be nice. In the following week, probably I'll work on that.

Maybe the lints step will fail for conan-rs, I don’t know if clippy was ran against much. Enabling this job and fixing the lints should be a separate PR if you decide to go for it

In this too.

CBenoit commented 8 months ago

Thank you, this is very appreciated!