Closed GwonsooLee closed 3 years ago
Merging #130 (11d2e5d) into main (8ba3fe3) will decrease coverage by
0.13%
. The diff coverage is2.15%
.
@@ Coverage Diff @@
## main #130 +/- ##
========================================
- Coverage 4.96% 4.83% -0.14%
========================================
Files 28 29 +1
Lines 4630 4718 +88
========================================
- Hits 230 228 -2
- Misses 4388 4478 +90
Partials 12 12
Impacted Files | Coverage Δ | |
---|---|---|
pkg/aws/elbv2.go | 0.00% <0.00%> (ø) |
|
pkg/constants/constants.go | 66.66% <ø> (ø) |
|
pkg/deployer/canary.go | 1.23% <0.00%> (-0.01%) |
:arrow_down: |
pkg/deployer/deployonly.go | 0.00% <0.00%> (ø) |
|
pkg/runner/runner.go | 4.40% <0.00%> (-0.03%) |
:arrow_down: |
pkg/deployer/deployer.go | 1.20% <25.00%> (-0.28%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8ba3fe3...11d2e5d. Read the comment docs.
Description
We add a new replacement type
DeployOnly
. This can be used when there is no health check process like bastion server, sample test service for local development, etc.With
DeployOnly
type, goployer will skip healthcheck process. It will provision a new version of autoscaling and delete the previous versions right away. It still checks whether all instances are successfully terminated.Follow-up Work (remove if N/A) Add end to end test code for deployonly type