search

DevopsArtFactory / goployer

AWS Deployer with Go
https://goployer.dev
Apache License 2.0
72 stars 13 forks source link

fixed error occurred in goroutine #140

Closed YoungJinJung closed 3 years ago

YoungJinJung commented 3 years ago

…outine, return error not just logging

Fixes: #nnn Related: Relevant tracking issues, for context Merge before/after: Dependent or prerequisite PRs

Description

fixed when deploy and delete command execute if error occurred in goroutine, return error not just logging

User facing changes (remove if N/A)

Follow-up Work (remove if N/A)

in this PR apply, then error occurred not just logging and passing if region instance isn't match ami architecture(ex, region instance type t3, and ami architecture amd64)

codecov[bot] commented 3 years ago

Codecov Report

Merging #140 (9bb4c70) into main (2a3c5b4) will increase coverage by 0.00%. The diff coverage is 4.46%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #140   +/-   ##
=====================================
  Coverage   5.29%   5.30%           
=====================================
  Files         29      29           
  Lines       5359    5451   +92     
=====================================
+ Hits         284     289    +5     
- Misses      5060    5147   +87     
  Partials      15      15
Impacted Files Coverage Δ
pkg/runner/runner.go 4.85% <4.46%> (+0.13%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2a3c5b4...9bb4c70. Read the comment docs.