search

DevopsArtFactory / goployer

AWS Deployer with Go
https://goployer.dev
Apache License 2.0
72 stars 13 forks source link

add vaildation comparing override spot instance types and AMI Image a… #141

Closed YoungJinJung closed 3 years ago

YoungJinJung commented 3 years ago

…rchitecture

Fixes: #139 Related: Relevant tracking issues, for context Merge before/after: Dependent or prerequisite PRs

Description

In issue #136, add override spot instance type option. But this modification isn't covered all case. For example, when AMI Architecture is x86_64 and spot instance type are arm64, this case doesn't occurred error. So In this PR, check AMI Architecture and Override spot instance type option input by user.

User facing changes (remove if N/A)

Follow-up Work (remove if N/A)

codecov[bot] commented 3 years ago

Codecov Report

Merging #141 (e391847) into main (5b08a9f) will decrease coverage by 0.01%. The diff coverage is 4.34%.

Impacted file tree graph

@@           Coverage Diff            @@
##            main    #141      +/-   ##
========================================
- Coverage   5.30%   5.28%   -0.02%     
========================================
  Files         29      29              
  Lines       5451    5467      +16     
========================================
  Hits         289     289              
- Misses      5147    5162      +15     
- Partials      15      16       +1
Impacted Files Coverage Δ
pkg/aws/ec2.go 0.00% <0.00%> (ø)
pkg/deployer/deployer.go 2.57% <14.28%> (-0.01%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5b08a9f...e391847. Read the comment docs.