search

DevopsArtFactory / goployer

AWS Deployer with Go
https://goployer.dev
Apache License 2.0
72 stars 13 forks source link

fix bug #53

Closed GwonsooLee closed 4 years ago

GwonsooLee commented 4 years ago

When checking metric time, I changed the check logic with time itself, not the period. Also added the test code for this.

codecov[bot] commented 4 years ago

Codecov Report

Merging #53 into main will increase coverage by 0.08%. The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##            main     #53      +/-   ##
========================================
+ Coverage   4.42%   4.50%   +0.08%     
========================================
  Files         19      19              
  Lines       2420    2420              
========================================
+ Hits         107     109       +2     
+ Misses      2307    2305       -2     
  Partials       6       6
Impacted Files Coverage Δ
pkg/aws/cloudwatch.go 1.72% <50.00%> (+1.72%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5f65164...11da9c5. Read the comment docs.