search

DevotedMC / BanStick

Player / IP / CIDR / VPN / Shared connection banning with a vengeance. Built for Spigot 1.16.4
http://www.devotedmc.com
BSD 3-Clause "New" or "Revised" License
1 stars 4 forks source link

Date and time doesn't work as instructed #14

Open GavJenks opened 4 years ago

GavJenks commented 4 years ago

/banstick crimeo 04/09/2020 04:17:24

bans me until 4/09/2020 00:00:00 with ban explanation message "04:17:24"

ProgrammerDan commented 4 years ago

hmm, looks like just confusing docs.

If only three params are presented it will assume first is who, second is date, third is message. This is expected behavior. Might not be clear from docs, though. If four params it should read third param as time and fourth as message, instead.

Can def check though but I'm not immediately seeing anything "wrong" here, although it is confusing from docs. However, basically the optional "message" has higher precedence then the optional time.

Arguably it should attempt to match it to a timestamp regex and use that to determine precedence.

On Fri, Apr 10, 2020 at 12:19 AM GavJenks notifications@github.com wrote:

/banstick crimeo 04/09/2020 04:17:24

bans me until 4/09/2020 00:00:00 with ban explanation message "04:17:24"

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/DevotedMC/BanStick/issues/14, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADD5DVDJCK4QAIN72QPSV3RL2M57ANCNFSM4MFGTMJQ .

GavJenks commented 4 years ago

it does the same with 4 arguments

GavJenks commented 4 years ago

message is just "04:17:24 blah" instead

ProgrammerDan commented 4 years ago

lmao well nevermind then. Thanks for the report!

On Fri, Apr 10, 2020 at 12:52 PM GavJenks notifications@github.com wrote:

message is just "04:17:24 blah" instead

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/DevotedMC/BanStick/issues/14#issuecomment-612118019, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADD5DSGVXHE5G326VRASJTRL5FDVANCNFSM4MFGTMJQ .