Some fixes and 'allowed groups for bastion group' feature

[Aleksey-Terzi]

Fixes and tweaks:

1) Fixed double messaging when player is right clicking in /bsi mode

2) Added new option commonSettings.cancelReinInBastionField By default it is "false" and everything works as previously. When it is "true" - then bastion will prevent "/ctr" action if player is not in bastion group and "/ctr" group is not allowed for bastion group

New functionality:

Introduced new feature "allowed groups for bastion group"

How it works:

1) Players could add groups to bastion groups

2) When some player haven't permissions on bastion group, but is member of "allowed group of this bastion" then he/she could place blocks using "/ctf allowed_group" or reinforce by using "/ctr allowed_group"even if commonSettings.cancelReinInBastionField = true

3) When such player (who is not in bastion group but in allowed group) is testing bastion field using /bsi - message will tell what group allowed to use

New permissions:

• BASTION_MANAGE_GROUPS - allows to modify "allowed group list"

New commands:

• bsga: description: Adds allowed group to bastion group usage: /bsga permission: Bastion.normal
• bsgd: description: Deletes allowed group from bastion group usage: /bsgd permission: Bastion.normal
• bsgl: description: List allowed groups in bastion group usage: /bsga permission: Bastion.normal

[DevotedServant]

Can one of the admins verify this patch? @ProgrammerDan @Maxopoly

"ok to test" will build any commits made to this PR "test this please" will build this PR once "retest this please" will make another single build for this PR "add to whitelist" will whitelist the creator of this PR and make jenkins automatically build any PRs made by him

[ProgrammerDan]

Need to fix the build for this, but all we need now is @Maxopoly to make a GUI for it!

[Maxopoly]

What would a Bastion GUI even do/show?

[ProgrammerDan]

In the context of this PR, it would show a management interface to add / remove "allowed" groups.

[Aleksey-Terzi]

Need to fix the build for this

What do you mean about this?

About GUI - I thought to have some kind integration with /nl (if this possible at all and not so hard), something like: 1) Group's "page" will have new items/commands - add and manage "bastion allowed groups" 2) Add - works something like add new member to group 3) Manage - allows to review list and remove existent groups

Also draw attention that player could add "allowed group" even if he/she is not member of this group. In other words - I (as player) could allow to use any existent group in my bastion field.

[ProgrammerDan]

Build is up on test now, migration worked beautifully