DevotedMC / Bastion

Minecraft plugin that allows players to place Citadel-reinforced blocks that stop block placement or enderpearl teleportation. Updated for Spigot 1.12
http://www.devotedmc.com
Other
2 stars 10 forks source link

Piston can still push a block into the first space of a bastion field #45

Closed GavJenks closed 6 years ago

GavJenks commented 6 years ago

Presumably the intended behavior is not being able to push ANY blocks into a bastion field, but currently, if one is placed 2 blocks outside, then a cobble or whatever placed 1 block outside (i.e. the closest you can place it without being blocked), and then you activate the piston, it will push the block successfully into the field. If cycling with a second block, it won't.

ProgrammerDan commented 6 years ago

Thanks, I'll check into this. It's probably due to rounding errors on the bastion field.

Does this apply to both square and circle bastions? Which have you tested?

GavJenks commented 6 years ago

Only square on civclassics On Sep 5, 2017 9:08 PM, "Daniel Boston" notifications@github.com wrote:

Thanks, I'll check into this. It's probably due to rounding errors on the bastion field.

Does this apply to both square and circle bastions? Which have you tested?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/DevotedMC/Bastion/issues/45#issuecomment-327368877, or mute the thread https://github.com/notifications/unsubscribe-auth/ABMtuC6u077M8D6YnANr625bM5CzmMD0ks5sfhq1gaJpZM4PNzpi .

ProgrammerDan commented 6 years ago

Oh, ofc:

https://github.com/DevotedMC/Bastion/blob/master/src/main/java/isaac/bastion/listeners/BastionDamageListener.java#L97

it's adding the list of blocks, but not "moving" them into their future position, only their current position...

ProgrammerDan commented 6 years ago

confirmed fixed in PR

ProgrammerDan commented 6 years ago

Fixed in 2.2.3