search

DevotedMC / Bastion

Minecraft plugin that allows players to place Citadel-reinforced blocks that stop block placement or enderpearl teleportation. Updated for Spigot 1.12
http://www.devotedmc.com
Other
2 stars 10 forks source link

Omit strength text #60

Closed Diet-Cola closed 3 years ago

ProgrammerDan commented 3 years ago

I don't really understand the impetus for this change, but it's a clean change lol

Diet-Cola commented 3 years ago

When trying to hand mine a bastion before this change, it would throw an NPE getting the strength of the bastion to put in the hover message of the 'Bastion deleted' text, this just simply omits the strength text to allow bastions to drop when broken by hand again

ProgrammerDan commented 3 years ago

Ahahahha, wow. Ok, ty.

Should it preferentially be gated behind a null check? Is there any other use where it is helpful?

On Sun, Mar 14, 2021, 04:54 Diet Cola @.***> wrote:

When trying to hand mine a bastion before this change, it would throw an NPE getting the strength of the bastion to put in the hover message of the 'Bastion deleted' text, this just simply omits the strength text to allow bastions to drop when broken by hand again

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/DevotedMC/Bastion/pull/60#issuecomment-798871496, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADD5DS7WOEQCS7XCXVYTSLTDR2TNANCNFSM4YBA3HWA .

Diet-Cola commented 3 years ago

I think I removed it here since its displayed when creating a bastion/removing a bastion/clicking a bastion for info, all of which has the strength of the bastion already available there by reinforcement