search

DevotedMC / CivModCore

Common Plugin Core derived from Humbug - Updated for Spigot 1.14.4
http://www.devotedmc.com
BSD 3-Clause "New" or "Revised" License
3 stars 11 forks source link

Remove mercury and metrics #20

Closed TealNerd closed 6 years ago

DevotedServant commented 6 years ago

Can one of the admins verify this patch? @ProgrammerDan @Maxopoly

"ok to test" will build any commits made to this PR "test this please" will build this PR once "retest this please" will make another single build for this PR "add to whitelist" will whitelist the creator of this PR and make jenkins automatically build any PRs made by him

Maxopoly commented 6 years ago

What's wrong with metrics

ProgrammerDan commented 6 years ago

repos down pretty often, causes weird intermediate build issues. I should rehost it in my build serv but lazy.

Does anyone actually check the metrics stats for these plugins?

Maxopoly commented 6 years ago

Probably not, got me convinced.

Assuming this compiles, it should be good to merge.

ProgrammerDan commented 6 years ago

ok to test

DevotedServant commented 6 years ago

Build finished.

ProgrammerDan commented 6 years ago

seems fine. Only thing really should be done is make a mention of 1.6.1 in the README that it's a hard fork w/ mercury removal. So any plugins that need mercury or call those functions that have been removed will break horribly unless you use the companion updates you've been working on.

There's already a list there of other hard forks, so it's a drop in.