search

DevotedMC / HiddenOre

Allows after-map generation positive rebalance via fine-control over custom drops - Anti-Xray - Built for Minecraft and Paper 1.16.4
https://www.devotedmc.com/hiddenore.html
MIT License
11 stars 29 forks source link

Piston Tracking Causes Chunk to Check Forever #25

Closed redmag3 closed 6 years ago

redmag3 commented 7 years ago

I get pages of

[03:42:50 INFO]: [HiddenOre] now world 08b29da0-2e43-4d40-a041-5d4eedc3210f chunk -73014443628 layersum 256 [03:42:50 INFO]: [HiddenOre] now world 08b29da0-2e43-4d40-a041-5d4eedc3210f chunk -73014443628 layersum 256 [03:42:50 INFO]: [HiddenOre] now world 08b29da0-2e43-4d40-a041-5d4eedc3210f chunk -73014443628 layersum 256 [03:42:50 INFO]: [HiddenOre] now world 08b29da0-2e43-4d40-a041-5d4eedc3210f chunk -73014443628 layersum 256 [03:42:50 INFO]: [HiddenOre] now world 08b29da0-2e43-4d40-a041-5d4eedc3210f chunk -73014443628 layersum 256 [03:42:50 INFO]: [HiddenOre] now world 08b29da0-2e43-4d40-a041-5d4eedc3210f chunk -73014443628 layersum 256 [03:42:50 INFO]: [HiddenOre] now world 08b29da0-2e43-4d40-a041-5d4eedc3210f chunk -73014443628 layersum 256 [03:42:50 INFO]: [HiddenOre] now world 08b29da0-2e43-4d40-a041-5d4eedc3210f chunk -73014443628 layersum 256 [03:42:50 INFO]: [HiddenOre] now world 08b29da0-2e43-4d40-a041-5d4eedc3210f chunk -73014443628 layersum 256 [03:42:50 INFO]: [HiddenOre] now world 08b29da0-2e43-4d40-a041-5d4eedc3210f chunk -73014443628 layersum 256 [03:42:50 INFO]: [HiddenOre] now world 08b29da0-2e43-4d40-a041-5d4eedc3210f chunk -73014443628 layersum 256 [03:42:50 INFO]: [HiddenOre] Piston event from Location{world=CraftWorld{name=civex},x=-260.0,y=28.0,z=6478.0,pitch=0.0,yaw=0.0} [03:42:50 INFO]: [HiddenOre] now world 08b29da0-2e43-4d40-a041-5d4eedc3210f chunk -73014443628 layersum 256 [03:42:50 INFO]: [HiddenOre] now world 08b29da0-2e43-4d40-a041-5d4eedc3210f chunk -73014443628 layersum 256 [03:42:50 INFO]: [HiddenOre] now world 08b29da0-2e43-4d40-a041-5d4eedc3210f chunk -73014443628 layersum 256 [03:42:50 INFO]: [HiddenOre] Piston event from Location{world=CraftWorld{name=civex},x=-259.0,y=28.0,z=6478.0,pitch=0.0,yaw=0.0}

when a piston clock is active in a chunk area, is there any way that a piston clock could just nerf a chunk completely and then HiddenOre can blacklist checking that chunk?

ProgrammerDan commented 6 years ago

So, those messages are basically telling you hiddenore has blacklisted that chunklayer. In order for it to know, it does a quick check against the layersum. That's what you're seeing. The "expensive" part of the check is skipped, and only this really quick, super cheap layersum check is done, and it can't really get any faster.

The only reason it seems "bad" is that logging occurs on every layersum check if debug is turned on. Turn off debug (strongly recommended) and this will stop being an issue.