search

DevotedMC / HiddenOre

Allows after-map generation positive rebalance via fine-control over custom drops - Anti-Xray - Built for Minecraft and Paper 1.16.4
https://www.devotedmc.com/hiddenore.html
MIT License
11 stars 29 forks source link

Added veins and better config flow #26

Closed TealNerd closed 6 years ago

TealNerd commented 7 years ago

@ProgrammerDan

ProgrammerDan commented 7 years ago

Figure this is feature complete and ready to merge? Did you add notes for how-to-configure the noise based spawn?

TealNerd commented 7 years ago

Yeah for now I added a new config in the new style, still need to refactor the other configs to the new format but that's a lot of work and I'm juggling like 5 projects right now :)

ProgrammerDan commented 7 years ago

Should I wait for those other fixes or just YOLO with this?

TealNerd commented 7 years ago

It's not really fixes per se, more the default configs are invalid, at this point in time it's yolo or wait for me to finish a bunch of stuff

ProgrammerDan commented 7 years ago

KK, no problem. Let me know if this as a PR holds you up any.

ProgrammerDan commented 7 years ago

@TealNerd did you have any more contributions to this PR?

TealNerd commented 7 years ago

Uh I think this is all I had, it's possibly I made more example configs but I don't think I did

ProgrammerDan commented 7 years ago

I will dig into this after my current upgrade cycle

ProgrammerDan commented 6 years ago

After considerable consideration and evaluation and the like, I'm closing this PR. It's my opinion that the direction taken here with veins is a bit too limiting, doesn't intersect well with existing features, and while offering many general positives (drop config sections, veins using noise functions) is overall not a net positive contribution in this form.

Thanks however for contributing. Note that this PR will be replaced momentarily with a more "in-flow" version adapting the best of this effort in a more streamlined manner with the rest of the mainline, updated featureset.

Thank you again for your contributions here, and I attempted to retain primary attribution for VeinConfig in my adaptations, and referenced your work on the CivClassic fork in the README and config example(s). Thanks!