From Gjum: Some snitch entries do not have item representation in /ja GUI

DevotedMC / JukeAlert

A plugin that creates a new block in Minecraft that records player entries and actions. Anti-grief tool. Built for Spigot 1.12

https://www.devotedmc.com/jukealert.html

BSD 3-Clause "New" or "Revised" License

2 stars 10 forks source link

From Gjum: Some snitch entries do not have item representation in /ja GUI #28

Closed ProgrammerDan closed 4 years ago

ProgrammerDan commented 7 years ago

I'll direct Gjum here to add more details

Gjum commented 7 years ago

some block types aren't visible in inventory guis, for example crops

when setting the item type to these blocks, the items will be treated as empty slots by the gui

a solution would be to display a different item instead

/ja gui with missing items for crop breaks

/jainfo output

GavJenks commented 5 years ago

Also getting a few players complaining about this:

GavJenks commented 5 years ago

They said that it even varied by the individual type of flower broken? Maybe it's "blocks introduced since whenever this was first coded" because something is badly hard coded somewhere?

Gjum commented 5 years ago

the code just calls new ItemStack(action.getMaterial()) which I guess returns an item stack with an invalid item (can't get rendered) in the case of certain blocks. this seems to be the place where this could be fixed.

ProgrammerDan commented 4 years ago

Resolved by #66