search

DevotedMC / NameLayer

A Citadel reinforcement group manager. Allows the creation of groups in Minecraft. Built for Spigot 1.14.4
https://build.devotedmc.com/job/Namelayer-master/
BSD 3-Clause "New" or "Revised" License
3 stars 8 forks source link

Using GUI while riding vehicle #32

Open Gjum opened 6 years ago

Gjum commented 6 years ago

In 1.12, inventory GUIs can be used while riding a vehicle (horse, boat, minecart etc.), which was not possible in 1.10 but has not been updated in the plugin code.

This can cause some unwanted erroneous behavior:

I was riding a cart when I tryed to use the namelayer graphical interface
the gui did not open, but when I pressed R to organize my inventory with the inventory tweaks mod 2 random people where removed from some random group which Im mod

This applies to other Civ plugins as well (e.g. FactoryMod /fm, JukeAlert /ja, Citadel /rein).

ProgrammerDan commented 6 years ago

I thought inventory opening suppression while in a vehicle has been intentional and true via Humbug for several years? Memory could be wrong on this but I don't remember it only being a technical limitation.

In any case yeah, sounds like this could be improved to take advantage of more stable underlying support, sounds great!

Ideally since support is shared by all plugins for inventory windows from CivModCore, this issue should be opened there as well (it can be left open here too, in case there are connected changes)

On Sun, Aug 19, 2018 at 9:24 PM Gjum notifications@github.com wrote:

In 1.12, inventory GUIs can be used while riding a vehicle (horse, boat, minecart etc.), which was not possible in 1.10 but has not been updated in the plugin code.

This can cause some unwanted erroneous behavior:

I was riding a cart when I tryed to use the namelayer graphical interface the gui did not open, but when I pressed R to organize my inventory with the inventory tweaks mod 2 random people where removed from some random group which Im mod

This applies to other Civ plugins as well (e.g. FactoryMod /fm, JukeAlert /ja, Citadel /rein).

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/DevotedMC/NameLayer/issues/32, or mute the thread https://github.com/notifications/unsubscribe-auth/AAY-js9qDn6W0bdhW80TCsdc8ntBzxpFks5uSg-_gaJpZM4WDNpf .