search

Devoxx4Kids-NPO / littil-frontend

Apache License 2.0
0 stars 4 forks source link

Connect teacher service to modal #16

Closed Anjanas-dh closed 2 years ago

github-actions[bot] commented 2 years ago

Coverage report

St.:grey_question:
 Category Percentage Covered / Total
🟢 Statements
80.18% (-4.15% 🔻)
 174/217
🟡 Branches
60.98% (-19.67% 🔻)
 25/41
🟡 Functions
66.67% (-13.02% 🔻)
 34/51
🟡 Lines
77.89% (-5.09% 🔻)
 148/190
Show new covered files 🐣
|
St.:grey_question:
| File | Statements | Branches | Functions | Lines | | :----------------------------------------------------------------------------------------------------------------------------------------------------: | :--------------------------------------------------------------------------------------------------------------------------------- | :--------- | :------- | :-------- | :---- | | 🟢 |
`...` / form-base.ts
| 100% | 100% | 100% | 100% | | 🟢 |
`...` / form-error-message.component.ts
| 100% | 100% | 100% | 100% | | 🟢 |
`...` / form-error-message.component.html
| 100% | 100% | 100% | 100% |
Show files with reduced coverage 🔻
|
St.:grey_question:
| File | Statements | Branches | Functions | Lines | | :----------------------------------------------------------------------------------------------------------------------------------------------------: | :--------------------------------------------------------------------------------------------- | :------------------------------------------------------------ | :----------------------------------------------------------- | :------------------------------------------------------------ | :------------------------------------------------------------ | | 🟢 |
`...` / login-modal.component.ts
|
94.12% (-5.88% 🔻)
| 100% |
84.62% (-15.38% 🔻)
|
93.88% (-6.12% 🔻)
| | 🟡 | utils/form.util.ts |
64.71% (-35.29% 🔻)
|
52% (-34.67% 🔻)
|
60% (-40% 🔻)
|
64.71% (-35.29% 🔻)
|

Test suite run success

90 tests passing in 12 suites.

Report generated by 🧪jest coverage report action from 62a917e1cc719b2dd102baa48d1536c0ee4646fa

tubbynl commented 2 years ago

fix voor de No provider for HttpClient error, de andere errors lijken "gewoon" failing tests?

tubbynl commented 2 years ago

heb de failing tests "gefixed", maar het lijken allemaal wel dingen waar we nog iets mee moeten; in de huidige situatie komt er iig een http-call uit de TeacherService na het invullen van het formulier met alle fields valid