Devscord-Team / Watchman

https://devscord-team.github.io/Watchman/
https://devscord-team.github.io/Watchman/
GNU General Public License v3.0
24 stars 12 forks source link

T/142 users controller get avatar #202

Closed Tramp2115 closed 2 years ago

codecov-commenter commented 2 years ago

Codecov Report

Merging #202 (9f336b5) into master (943df4d) will increase coverage by 0.25%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
+ Coverage   49.65%   49.90%   +0.25%     
==========================================
  Files         276      276              
  Lines        5583     5583              
  Branches      410      410              
==========================================
+ Hits         2772     2786      +14     
+ Misses       2712     2698      -14     
  Partials       99       99              
Impacted Files Coverage Δ
Devscord.DiscordFramework/ControllersService.cs 53.89% <ø> (ø)
...Discord/Areas/Users/Controllers/UsersController.cs 32.81% <100.00%> (+20.31%) :arrow_up:
...n.Discord/Areas/Users/BotCommands/AvatarCommand.cs 100.00% <0.00%> (+100.00%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 943df4d...9f336b5. Read the comment docs.

DavidPL-coder commented 2 years ago

To tak ma być? @Marcin99b Zrzut ekranu 2022-03-17 174328

DavidPL-coder commented 2 years ago

Zauważyłem, że gdy użytkownik bez avatara wpisze komende -avatar to wyskakuje wyjątek w linii 47 w UsersController.cs.

Marcin99b commented 2 years ago

To tak ma być? @Marcin99b Zrzut ekranu 2022-03-17 174328

Nie, ale to sie naprawi później (żeby przypadkiem czegoś nie zepsuć)

Robiłem jakiś czas temu aktualizacje hangfire i w obecnej wersji jeszcze działa stary sposób użycia, ale informują że w przyszłości trzeba będzie korzystać z innego