search

Devsh-Graphics-Programming / Nabla

Vulkan, OptiX and CUDA Interoperation Modular Rendering Library and Framework for PC/Linux/Android
http://devsh.eu
Apache License 2.0
460 stars 58 forks source link

Sized floats and ints #579

Closed nahiim closed 11 months ago

nahiim commented 11 months ago

Description

Use sized floats and ints in entire HLSL codebase

devshgraphicsprogrammingjenkins commented 11 months ago

[CI]: Can one of the admins verify this patch?

devshgraphicsprogramming commented 11 months ago

can you please BxDF stuff and the rest separate

nahiim commented 11 months ago

can you please BxDF stuff and the rest separate

I should have changes per directory in seperate commits?

devshgraphicsprogramming commented 11 months ago

can you please BxDF stuff and the rest separate

I should have changes per directory in seperate commits?

separate PRs / branches

nahiim commented 11 months ago

/execute order 0x45ull

devshgraphicsprogramming commented 11 months ago

bwtw don't touch anything in the bxdf directory

nahiim commented 11 months ago

bwtw don't touch anything in the bxdf directory

I already changed the ints and floats. And the "out" variables. Should I revert?

devshgraphicsprogramming commented 11 months ago

bwtw don't touch anything in the bxdf directory

I already changed the ints and floats. And the "out" variables. Should I revert?

don't revert, just abandon the branch and copy over what you need to some other branch