Devsh-Graphics-Programming / Nabla

Vulkan, OptiX and CUDA Interoperation Modular Rendering Library and Framework for PC/Linux/Android
http://devsh.eu
Apache License 2.0
444 stars 48 forks source link

Bitscan fix #650

Closed kpentaris closed 5 months ago

kpentaris commented 5 months ago

Description

Subgroups invocations greater than 32 were using inappropriate subgroupLtLe mask (using the first when they should be using the one matching their subgroup invocation DWORD)

Testing

To properly test a gpu with max subgroup size > 32 is required (e.g. AMD)

TODO list:

N/A

devshgraphicsprogrammingjenkins commented 5 months ago

[CI]: Can one of the admins verify this patch?

kpentaris commented 5 months ago

ffs not sure why these other commits came about -_-