"treat all warnings as errors" cmake rule, macro for disabling 3rdparty includes' warnings

Devsh-Graphics-Programming / Nabla

Vulkan, OptiX and CUDA Interoperation Modular Rendering Library and Framework for PC/Linux/Android

http://devsh.eu

Apache License 2.0

443 stars 48 forks source link

"treat all warnings as errors" cmake rule, macro for disabling 3rdparty includes' warnings #687

Open YasInvolved opened 2 months ago

YasInvolved commented 2 months ago

"treat all warnings as error" cmake rule, macro for disabling 3rdparty includes warnings

Description

Useful tools for dealing with warnings have been added

Testing

It wasn't really tested at all

TODO list:

Fix warnings with these tools

devshgraphicsprogrammingjenkins commented 2 months ago

[CI]: Can one of the admins verify this patch?

AnastaZIuk commented 2 months ago

we will test it with CI once you wrap all our 3rdparty includes present in Nabla sources with those macros

AnastaZIuk commented 2 months ago

okay I need to think about it if std includes generate warnings we actually could silent them too

AnastaZIuk commented 2 months ago

okay I need to think about it if std includes generate warnings we actually could silent them too

silent all 3rdparty which are included into Nabla first, if there are errors from directly std after you do it we may silent the headers they come from too

devshgraphicsprogramming commented 2 months ago

okay I need to think about it if std includes generate warnings we actually could silent them too

they never should

AnastaZIuk commented 2 months ago

as you are on it you could turn all of our 3rdparty include directives you are wrapping with the macro which use <> into ""