search

Devsh-Graphics-Programming / Nabla

Vulkan, OptiX and CUDA Interoperation Modular Rendering Library and Framework for PC/Linux/Android
http://devsh.eu
Apache License 2.0
493 stars 59 forks source link

device_features: actually disable `alphaToOne` #735

Closed alichraghi closed 3 months ago

alichraghi commented 3 months ago

Description

in https://github.com/Devsh-Graphics-Programming/Nabla/commit/21d6979d44837d5f31ba7552236e9d2a1b6b1826, alphaToOne was set to false but somehow regressed later.

Testing

I was able to run helloswapchain example after this change.

devshgraphicsprogrammingjenkins commented 3 months ago

[CI]: Can one of the admins verify this patch?

devshgraphicsprogramming commented 3 months ago

@nipunG314 check and merge

@alichraghi why are you force pushing to your branches?

alichraghi commented 3 months ago

why are you force pushing to your branches?

I didn't know about the commit signing thing at first.

nipunG314 commented 3 months ago

@alichraghi This change happened when we transitioned from a handwritten header file to a generated one. In the original header, the value was true.

This patch is not required.

alichraghi commented 3 months ago

But either way this should be set to false because even some semi new-gen AMD GPUs doesn't support it. (@Erfan-Ahmadi can verify this).

Erfan-Ahmadi commented 3 months ago

Yes @nipunG314 this value should be false, it was changed here but ever applied to the json https://github.com/Devsh-Graphics-Programming/Nabla/commit/21d6979d44837d5f31ba7552236e9d2a1b6b1826