search

Devsh-Graphics-Programming / Nabla

Vulkan, OptiX and CUDA Interoperation Modular Rendering Library and Framework for PC/Linux/Android
http://devsh.eu
Apache License 2.0
492 stars 59 forks source link

`git_info.h` debate #784

Open alichraghi opened 1 week ago

alichraghi commented 1 week ago

git_info.h should probably not be a public header or at least should be grouped under nbl/ as it may conflict with other projects using Nabla. https://github.com/Devsh-Graphics-Programming/Nabla/blob/de62785b6db71a04154fd6ba4039ce1d87193e19/include/nbl/video/ILogicalDevice.h#L17

See also https://github.com/Devsh-Graphics-Programming/Nabla/pull/775#discussion_r1834065004

AnastaZIuk commented 3 days ago

git_info.h should probably not be a public header

it should be in public headers, metadata should be accessible for projects linking Nabla (or gtml library directly)

nbl/ as it may conflict with other projects using Nabla

however we could have better include path for each meta header