search

Devsoc-BPGC / DoJMA

DoJMA news app for BITS Pilani K K Birla Goa Campus students
6 stars 18 forks source link

Utilities Section remade #143

Closed aryanagarwal15 closed 5 years ago

aryanagarwal15 commented 6 years ago

This is in reference to #79

@Rushi98 Only three things are to be done: A) I was not sure how to get menus from firebase here in Realm. So I've just created a viewholder and adapter class. You probably can add that logic. Won't take much time. B) Currently only Taxi no. are visible and I was not able to add logic for scooty and car rental numbers. I really think the approach used in UtilitiesContactsActivity is very bad. Would prefer if it is done better. C) As I didn't have data for menu currently. I have not implemented pinch to zoom feature in viewholder. Will do that in future commits.

Lets keep this PR active and develop on it. As I require collaborative help, I would appreciate if all the work is done in this PR.

Rushi98 commented 6 years ago

screenshot_20180820-233529 screenshot_20180820-233537 @aryanagarwal15 the ui needs improvement,

  1. Calculate span count based on device width
  2. Make the label height wrap content, max width constant
aryanagarwal15 commented 6 years ago

@Rushi98 I am not sure if many people use the landscape mode in our Application. We probably can make this landscape only app (Up for discussion). I'll fix UI problems you pointed out in 1st screenshot.

Rushi98 commented 6 years ago

It's not hard to support landscape grid layout. See how span count was calculated in the code you replaced.

Rushi98 commented 5 years ago

closing as out-of-date