search

Devsoc-BPGC / DoJMA

DoJMA news app for BITS Pilani K K Birla Goa Campus students
6 stars 18 forks source link

Load full screen view of images . #67

Closed hardik124 closed 6 years ago

hardik124 commented 7 years ago

Currently mess menu is not not opened in full screen on clicking on it . A new feature should be added in order to enable users to open images in full screen and save and share them .

hardik124 commented 7 years ago

@kukreja-vikramaditya If this issue is valid , i would like to work on it.

kukreja-vikramaditya commented 7 years ago

Approved. Check old commits to see how this was done earlier

hardik124 commented 7 years ago

@kukreja-vikramaditya , can we add a seperate activity to view images in full screen . It would look something like . screenshot from 2017-04-23 01-25-57

kukreja-vikramaditya commented 7 years ago

@yashsharan @shreyasnbhat @shubham-kumar1410

Please share views on this

@hardik124 I don't see a reason why this cannot be done in the existing activity using existing viewpager

hardik124 commented 7 years ago

It could be. I just suggested this. I will try to implement it using existing view pager.

On Sun, Apr 23, 2017, 10:45 AM Vikramaditya Kukreja < notifications@github.com> wrote:

@yashsharan https://github.com/yashsharan @shreyasnbhat https://github.com/shreyasnbhat @shubham-kumar1410 https://github.com/shubham-kumar1410

Please share views on this

@hardik124 https://github.com/hardik124 I don't see a reason why this cannot be done in the existing activity using existing viewpager

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/MobileApplicationsClub/DoJMA/issues/67#issuecomment-296420327, or mute the thread https://github.com/notifications/unsubscribe-auth/AGV4XM82d5TZUFxZyMQMk0n6459r5CMJks5ryt5xgaJpZM4M-fPk .