Devsoc-BPGC / DoJMA

DoJMA news app for BITS Pilani K K Birla Goa Campus students
6 stars 18 forks source link

Move Archives and Live LCD News to utilities. #79

Open tanmaydixit opened 6 years ago

tanmaydixit commented 6 years ago

The archives and LCD news are parts of the nav drawer for now. Move Archives and Live LCD News to utilities fragment as another 2 cards. link for LCD news is cc.bits-goa.com/enotice/Lcd.php

Rushi98 commented 6 years ago

@tanmaydixit cc.bits-goa.com/enotice/Lcd.php doesn't work

tanmaydixit commented 6 years ago

It works on bits net. Its an intranet site.

aryanagarwal15 commented 6 years ago

@tanmaydixit We have a lot of archives dating back to 2007. I have data for all in PDF Format for those archive. Instead of archives section pointing towards issue.com link can we have a separate activity where we can show thumbnails of all the archives and an in app PDF reader?

Also it would be better if we just move Live LCD news to links tab. This way you won't have to create extra section for that,

Rushi98 commented 6 years ago

In app PDF reader isn't possible to implement easily.

aryanagarwal15 commented 6 years ago

Oh Ok. then we can just let them download the issue in PDF Format and read on in-phone pdf reader.

Agrim1234 commented 6 years ago

on it

aryanagarwal15 commented 6 years ago

@Agrim1234 can you please inform on how are you planning to implement archives? I have a lot of PDF dating back to 2007. I want the pdfs to be downloadable. also users should get to know if they have previously downloaded any PDF or not (With a tick right or something). Also all PDFs should automatically detect cover as thumbnail. The recycler view should show The thumbnail and Issue Name. The data needs to be pulled from firebase.

Rushi98 commented 6 years ago

@aryanagarwal15 Is it possible for you to upload thumbnails for the pdfs as well?

aryanagarwal15 commented 6 years ago

@Rushi98 sure. I'll make that happen. Please suggest optimum width and height.

Rushi98 commented 6 years ago

depends on UI but a decent one with 16:9 ish aspect ratio and would mostly work and refering to this width 1440 px seems maximum on smartphone. So 1440 x 2560 px. @Agrim1234 please confirm.

Agrim1234 commented 6 years ago

I think 4:3 would be better

Agrim1234 commented 6 years ago

and most optimum

aryanagarwal15 commented 6 years ago

The PDFs are in vertical format. So Please suggest Vertical aspect ratio. Also @Agrim1234 please note the archive recycler view should show two issues side by side.

Agrim1234 commented 6 years ago

I think 1:1 would be best. rest u can decide. screenshot-2018-7-7 vertical aspect ratio - google search

aryanagarwal15 commented 6 years ago

Lets go with 2:3. It looks good.

Rushi98 commented 6 years ago

@aryanagarwal15 If you have a design in mind tell it now, we will wait

Rushi98 commented 6 years ago

@Agrim1234 Since @aryanagarwal15 has not responded yet, can you post a mockup thingy of your design (for list) here?

aryanagarwal15 commented 6 years ago

@Rushi98 I've asked my designers to come up with a design for this. Please give some time. Till then put this on hold.

aryanagarwal15 commented 6 years ago

Ok so first designs are in. For revamping the UI our designers have come up with this:

Here's the link to all svg files used here for icons : https://drive.google.com/open?id=1yXhNmM1bQhi7m8gygl8d64RlvElkumKP @Rushi98 if you approve this design we can start working towards building this. Also please give design credits to "Abhinav Gupta" as he has designed this screen.

More designs to follow.

Rushi98 commented 6 years ago

looks good 👍 . @tanmaydixit have a look.

Agrim1234 commented 6 years ago

I think the menus should be another option in utilities just like links and upon clicking on it the menus activity would open and in that activity all these menu would be displayed.

aryanagarwal15 commented 6 years ago

@Agrim1234 after conducting an internal survey we found out that BITSians majorly use our utilities screen for checking menus. So it made sense to move it to another section. Moreover this looks more organised.

aryanagarwal15 commented 6 years ago

@Rushi98 More designs are in. Prepared by Abhinav Gupta.

Archives:

Reorganised Utilities screen:

Please approve the designs. Also can you give me a timeframe till when can it be implemented?

Agrim1234 commented 6 years ago

then it's ok

Rushi98 commented 6 years ago

@aryanagarwal15 is there something else like "PUBLICATIONS"? If not, it can be removed. Also, the title should be Archives.

aryanagarwal15 commented 6 years ago

@Rushi98 I agree with both of the mistakes pointed out by you. lets remove "Publications" and change Archive to Archives. I believe Photoshop is used UI design so it is not possible to get exact dimensions. Please use these screenshots for just blueprint of the screens.

Agrim1234 commented 6 years ago

@aryanagarwal15 give the design for downloading icon(the icon which will appear when the archive is not downloaded) and the progress bar(which will appear when the archive is being downloaded) if u have in mind any otherwise we will go with these screenshot-2018-7-14 circular progress bar in android screenshot-2018-7-14 pdf download icon - google search

aryanagarwal15 commented 6 years ago

@Agrim1234 this looks fine. Go ahead with these.

aryanagarwal15 commented 6 years ago

@Agrim1234 Whats the progress? Please ensure that this is done before 25th. We have to push a launch by then.

Agrim1234 commented 6 years ago

I have made the archives activity and i will do the utilities UI redesign later.

aryanagarwal15 commented 6 years ago

Later as in? Also how do you download the pdf in archives? Please share an example.

Agrim1234 commented 6 years ago

some time later(most probably 10-20 days) as it is not so urgent. Upon clicking on an archive for the first time, archive would be downloaded and stored in the archives folder of external storage directory of dojma. if the user clicks for second time the archive will open in pdf reader app screenshot_20180719-215505 screenshot_20180719-215510 and the download sign would be like this screenshot_20180716-135021

Agrim1234 commented 6 years ago

the 2 image shows what will happen after clicking 2 time

aryanagarwal15 commented 6 years ago

@Agrim1234 How Do I update the archive page? As in where do I put the pdf for archives?

Agrim1234 commented 6 years ago

See title and image url would be Taken from firebase and the pdf file would be taken from firebase storage as said by rushi

aryanagarwal15 commented 6 years ago

@Agrim1234 I still cannot access archives. Please share elaborate step by step documentation for adding archive

Agrim1234 commented 6 years ago

see https://firebase.google.com/docs/storage/android/download-files using the documentation given on this link i created a reference to the archive in firebase storage archives folder and using the method given in download to a local file section i downloaded the archive in the archives folder of the external storage directory related to dojma and after storing it in memory i am using pdf reader app to open it. And it is working flawlessly in my phone, so everything is right as far as firebase is concerned. I think the problem is memory related.

aryanagarwal15 commented 6 years ago

@Agrim1234 Sorry man it's not working. I've tested it on multiple devices and emulators. Please fix it asap.

Agrim1234 commented 6 years ago

I am trying wait for some time.

jainvandit99 commented 5 years ago

ezgif com-video-to-gif Not Fond Of the Design, Took my time to redesign it

aryanagarwal15 commented 5 years ago

@jainvandit Looks gr8!