search

Devsoc-BPGC / Events

Modular app for all events
3 stars 14 forks source link

live photo upload system #5

Closed Rushi98 closed 6 years ago

Rushi98 commented 6 years ago
  1. upload pics during the event itself
  2. captions
  3. liking the photos to that events activity
aayushsingla commented 6 years ago

are we going to do this? if yes, can i take this up?

Rushi98 commented 6 years ago

There are some details we need to finalize:

  1. how to upload the pics? firebase cloud storage, user's google drive or something else?
  2. will this feature be linked to other features, and details if so.
  3. database structure for this?

After these (and more if need arises) are resolved, you can take it up.

aayushsingla commented 6 years ago

Any suggestion from your side for storing pics? @Rushi98

Rushi98 commented 6 years ago

You can start with any of the two you are comfortable with. Try to keep the code for upload etc. modular so that if there is some issue (ex. we hit 5 GB limit of cloud storage) we are able to swap one for another easily.

aayushsingla commented 6 years ago

I was thinking to use Flickr API. i think it is cool for all our needs. https://www.flickr.com/services/api/

Rushi98 commented 6 years ago

We can't. Flickr guidelines specifically ask not to use their service as replacement for content server and we should respect that.

https://www.flickr.com/help/guidelines

aayushsingla commented 6 years ago

So,if we cant use their API then i will use google drive REST API for it. In database we will use a separate node to store urls for photo and the additional meta-data with it. Linking to other features can be decided once we other features are complete and we have a working this feature.For now, is it ok to have a recycler view for displaying pics, something insta type? And shall there be a separate fragment or an activity for this?

Rushi98 commented 6 years ago

Separate activity for the main feature. And a fragment to be shown in home activity

Rushi98 commented 6 years ago

@aayushsingla See https://developer.android.com/training/camera/photobasics to see how to take photos with existing camers apps.

aayushsingla commented 6 years ago

@Rushi98 the image chooser i have used gives this option in the status bar when we go to select the image

Rushi98 commented 6 years ago

Why use an external library when native code is easily available?

aayushsingla commented 6 years ago

External Library allows you to select images already stored on phone.For this you wont need any file explorer and you can also limit the number of images to be selected.It also takes care of most things like asking for storage permission. The library is very small.So, i guess we dont need to worry. And it can also be customised. :p

Rushi98 commented 6 years ago

Native camera apps also allows to select previously captured images. (It also has advantage of filtering out non photo images. So no cat gifs :P ) User is already familiar with native camera ui.

aayushsingla commented 6 years ago

I don't think Ui will be a problem because it is simpler then the actual one. However the major advantages of using image picker were: 1.) it doesnot require prescence of any external app like gallery, camera or photos app. 2.)It takes care of all the the permissions to be asked and the cases user denies the permission.

If you still think native camera app is better, I will remove the lib in future commits.

Rushi98 commented 6 years ago

I do think it's better to use native capabilities than third party libraries as we have all control up from basics.

tanmaydixit commented 6 years ago

This will continue in #40