search

Dewb / monome-rack

VCV Rack plugin for monome Eurorack modules
GNU General Public License v2.0
226 stars 13 forks source link

Don't open OSC listening port on non-local interfaces without express user intent #196

Closed ivxvm closed 1 month ago

ivxvm commented 7 months ago

After I install monome collection the first time I added some monome modules to patch (grid and teletype) I got this windows 10 firewall warning window asking to trust public/whatever connection to the vcv rack. This didn't happen since I first installed vcv rack, so this is very suspicious. Do any of those modules connect to internet?

Dewb commented 7 months ago

These modules use OSC, a network protocol, to communicate with the serialosc server to provide device support for local and remote devices. This involves opening a listening port for messages from the device, so the Windows message is not unexpected.

Dewb commented 7 months ago

I'll leave this issue open because it should be possible in the future to only open this port on the local interface to avoid the firewall dialog. If people want to use devices attached to a remote host, there could be an explicit option to enable listening to ports on public interfaces.

Dewb commented 1 month ago

Fixed by #198.