search

Dewb / monome-rack

VCV Rack plugin for monome Eurorack modules
GNU General Public License v2.0
226 stars 13 forks source link

Restore support for older-protocol grids (real and virtual) #44

Closed Dewb closed 2 years ago

Dewb commented 5 years ago

The 0.6 branch supported both modern grids (mext protocol varibright) and older non-varibright models, but support for older protocols was somewhat tenuous since I don't have easy access to physical devices. The new connection system for 1.0 necessitated changing the way grid detection works, so this support has been removed until it can be reverified.

Separately, for the virtual grids, the new Rack library preview makes having separate varibright and series models in the library less desirable. The new plan is to have a single module per size, but add a right-click menu option to pick the protocol to emulate (and also the LED color?)

CarlColglazier commented 5 years ago

Current behavior seems to treat the 40h as half a 128. Is this expected?

joopvdl commented 5 years ago

I have an older non-varibright model. Happy to help out with testing etc (of course, I am also missing support for it quite a lot)

Op wo 25 sep. 2019 om 17:05 schreef carl colglazier < notifications@github.com>:

Current behavior seems to treat the 40h as half a 128. Is this expected?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Dewb/monome-rack/issues/44?email_source=notifications&email_token=AH6IMGNL3WZADAGYG3ENYBTQLN44FA5CNFSM4HRS7WU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7SHV4I#issuecomment-535067377, or mute the thread https://github.com/notifications/unsubscribe-auth/AH6IMGNCQZZIVKZ3BTKU6XDQLN44FANCNFSM4HRS7WUQ .

joopvdl commented 4 years ago

Don't want to sound pushy, but is there any chance we will get support for the older grids back?

Dewb commented 4 years ago

Apologies for the delay. Took the summer off from side projects (to get married!) and still catching up on the backlog.

Chances will go up if I can get my hands on an older proto grid! Feel free to let me know if you see any cheap ones on reverb/lines/craigslist etc. Or just mail me one, lol.

joopvdl commented 4 years ago

First, congratulations! Secondly: You could have borrowed mine, were there no ocean between us. But for now, that's a bit impractical. Are the differences between the boards that big? (Just curious)

Op ma 2 dec. 2019 om 01:12 schreef Michael Dewberry < notifications@github.com>:

Apologies for the delay. Took the summer off from side projects (to get married!) and still catching up on the backlog.

Chances will go up if I can get my hands on an older proto grid! Feel free to let me know if you see any cheap ones on reverb/lines/craigslist etc. Or just mail me one, lol.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Dewb/monome-rack/issues/44?email_source=notifications&email_token=AH6IMGKS37AUT3IO2D46YV3QWRHGFA5CNFSM4HRS7WU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFR2MFQ#issuecomment-560178710, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH6IMGNUUSKR7QBOW2K5SF3QWRHGFANCNFSM4HRS7WUQ .

Dewb commented 3 years ago

Hello everyone still following this issue: support for older protocols has just been merged back into the plugin. I can test older protocols with the virtual grids, but for hardware I only have Mext-FTDI and Mext-CDC grids to test with (the latest two models) so I have no way to confirm whether 40h/Arduinome-FTDI or Series-FTDI function correctly.

I hope to have this support as part of the 1.0.0-alpha2 release. If you'd like to help test before then, you can download temporary prerelease builds here: https://github.com/Dewb/monome-rack/actions/runs/1276741052

If you're able to give me feedback on the behavior and performance with 40h/Series hardware, I'd greatly appreciate it! Apologies for this feature being out of a release for so long, thanks for sticking around.

suit4 commented 3 years ago

I have a 40h/Arduinome-FTDI and can confirm that it is working an communication with the plugin.

The visualisation on the virtual grid looks different to that one on the real grid, but I guess this is a side effect of the Arduinome not being able to display variable brightness. Those old grids are only capable of off and on.

Dewb commented 3 years ago

That's great news, thanks for the feedback!

By default, the virtual grids simulate the most recent varibright protocol. You can switch them into older protocols from the right-click menu. If you set a virtual grid to 40h protocol, does it match what you see on your hardware?

image
suit4 commented 3 years ago

Huh? Is that part of the release package v1.0.0-alpha1? Can't see that settings … do I have to compile from code first?

ok, VCV Rack and monome-rack plugin compiled.

Starting with ./Rack -d

I added a virtual grid 128.

40h grid does initially not show up. Reconnecting the USB cable to the Arduinome makes it show up in the plugins. Connecting one of the plugins to the Arduinome results in a application crash.

Output: FRONT HOLD FRONT HOLD[1] 52036 bus error ./Rack -d

Dewb commented 3 years ago

The build I'd like you to test is linked in a comment above, sorry if that wasn't obvious -- it's in the Artifacts section here: https://github.com/Dewb/monome-rack/actions/runs/1276741052

nay-seven commented 3 years ago

I can also confirm a better result , no more flickering leds with an old 40h/Arduinome-FTDI ! Nice, thanks a lot !

joopvdl commented 3 years ago

My 40h seems to function properly Thank you for this!

On Mon, 27 Sep 2021, 23:40 Michael Dewberry, @.***> wrote:

Hello everyone still following this issue: support for older protocols has just been merged back into the plugin. I can test older protocols with the virtual grids, but for hardware I only have Mext-FTDI and Mext-CDC grids to test with (the latest two models) so I have no way to confirm whether 40h/Arduinome-FTDI or Series-FTDI function correctly.

I hope to have this support as part of the 1.0.0-alpha2 release. If you'd like to help test before then, you can download temporary prerelease builds here: https://github.com/Dewb/monome-rack/actions/runs/1276741052

If you're able to give me feedback on the behavior and performance with 40h/Series hardware, I'd greatly appreciate it! Apologies for this feature being out of a release for so long, thanks for sticking around.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Dewb/monome-rack/issues/44#issuecomment-928310820, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH6IMGMGMXDY7FQZ562ROKLUEDQEJANCNFSM4HRS7WUQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

suit4 commented 3 years ago

Arduinome works perfectly, no flickering. Great job! Thank you, Me screaming: it's aliiiiiiiiiiiiveeeeee!!!

(Had to install the beta driver 1.4.7 for MacOS from https://ftdichip.com/drivers/vcp-drivers/ but that is Serialosc-FTDI-stuff)

Dewb commented 3 years ago

Thanks so much for the testing everyone! I'm in the process of sourcing my own 40h so I can more easily ensure support going forward.

The next alpha will include a bunch of additional grid performance improvements, if you want to check that those are also behaving correctly with the 40h, a new build is here: https://github.com/Dewb/monome-rack/actions/runs/1298997917

joopvdl commented 3 years ago

The biggest disadvantage of the 40h is you cannot reach the two keys top right, so you cannot access those functions. But that's probably also true with hardware.

On Sat, 2 Oct 2021, 22:38 Michael Dewberry, @.***> wrote:

Thanks so much for the testing everyone! I'm in the process of sourcing my own 40h so I can more easily ensure support going forward.

The next alpha will include a bunch of additional grid performance improvements, if you want to check that those are also behaving correctly with the 40h, a new build is here: https://github.com/Dewb/monome-rack/actions/runs/1298997917

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Dewb/monome-rack/issues/44#issuecomment-932817297, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH6IMGNZPVYVGGOENERSNMTUE5UTFANCNFSM4HRS7WUQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Dewb commented 3 years ago

Yeah, not all of the modules support 8x8 grids fully in the main branch firmware. There's an issue to track that here: https://github.com/Dewb/monome-rack/issues/61

Dewb commented 2 years ago

I believe this has been solved, please let me know about any issues with older hardware!

suit4 commented 2 years ago

Short update: after OS upgrades, you might need to reinstall the FTDI driver. Beta driver 1.4.7 for MacOS from https://ftdichip.com/drivers/vcp-drivers/