search

Dewb / monome-rack

VCV Rack plugin for monome Eurorack modules
GNU General Public License v2.0
226 stars 13 forks source link

Invalid module tags in plugin.json #70

Closed cschol closed 3 years ago

cschol commented 3 years ago

I know this is a WIP, but I ran it through the library integration process and encountered the following issues:

[monome-rack] Validating plugin.json...FAILED
[monome-rack] Issues found in `plugin.json`:
whitewhale: invalid module tags: sequencer, clock, digital, hardware clone, external
earthsea: invalid module tags: sequencer, digital, hardware clone, external
meadowphysics: invalid module tags: sequencer, clock, digital, hardware clone, external
teletype: invalid module tags: sequencer, clock, logic, function generator, digital, hardware clone, external
grid128: invalid module tags: controller
grid64: invalid module tags: controller
grid256: invalid module tags: controller
--Valid tags are defined in https://raw.githubusercontent.com/VCVRack/Rack/v1/src/tag.cpp
Dewb commented 3 years ago

I see “clock” should be replaced with “clock generator” or “clock modulator”, but the rest of those tags look legal according to https://vcvrack.com/manual/Manifest#modules-tags. Is there a new list of legal tags for v2?

cschol commented 3 years ago

I think the tags need to be capitalized. They will be lower-case matched within Rack.

Dewb commented 3 years ago

The docs say case doesn't matter:

All tags must match the following strings, case-insensitive.

Not sure why earthsea and meadowphysics aren't also flagged, since they use some of the same tags. Do you have a link to the validation script?

cschol commented 3 years ago

Fixed the formatting issues with the output.

It's weird. I run the same script now and it says all of the tags are correct. Maybe I was on a different branch? Never mind then. Sorry for the noise.