search

Dewb / monome-rack

VCV Rack plugin for monome Eurorack modules
GNU General Public License v2.0
225 stars 13 forks source link

Teletype knob and param values are not correct. #72

Closed jpnielsen closed 2 years ago

jpnielsen commented 2 years ago

Teletype knob max is 16383 param = "16380" both should be 16384 ?

IN max = 16384 is OK

Dewb commented 2 years ago

Thanks for the report! 16383 is the correct default maximum value for both, so IN is wrong. By "param = 16380", do you mean the tooltip, meaning you're testing the v2 build?

jpnielsen commented 2 years ago

meaning you're testing the v2 build?

Exactly, i got the binary for Windows from here: "https://github.com/Dewb/monome-rack/actions/runs/1314401138"

with param=16380 i meant:

When I set the knob to it's maximum, it shows "16383" in the tooltip - when entering "PARAM" I get 16380 in the display.

Entering IN, displays 16384 when a fader from your fadebak is connected and set to max.

You now say that 16383 is the correct value... Then this must be wrong ?

"Turn left and right and repeat the command (remember UP ARROW). You’ll quickly discover that the range is 0-16384, the same as how 0-10v is represented" https://monome.org/docs/teletype/studies-4/

You allready did a fix earlier https://github.com/Dewb/monome-rack/issues/53#issue-991590157

Dewb commented 2 years ago

Yeah, it looks like the previous fix was incomplete. The docs are inconsistent, the manual describes IN and PARAM as having a range of 0-16383, which is the range representable in a 14-bit integer. Also, if you calibrate the hardware module with PARAM.CAL.MAX, your top end will be set to 16383. I believe the text in study 4 is off by one.

Dewb commented 2 years ago

IN and PARAM are now both 0-16383 (in the main branch.) Tooltips still need to be adjusted in v2.