stratified code update 7/27

Dewberry / pfra-hydromet

Tools for developing pluvial (excess rainfall) and fluvial scenarios for probabilistic flood risk analyses

Apache License 2.0

27 stars 16 forks source link

stratified code update 7/27 #57

Closed csmithud closed 4 years ago

csmithud commented 4 years ago

Shane - please see the revised code that addresses your comments. Responses are included to the comments. We also addressed the comments relating to pulling the runoff functions into the .py files.

The nested hyetograph notebook can be deleted now. I renamed it _void_nested_hyetograph for now. Also the Runoff Notebook can be deleted per Mark's update.

ShaneMPutnam commented 4 years ago

Hydro4_samples.ipynb:

The inputs description is still the same description copied from EventsTable.ipynb, should be updated.

ShaneMPutnam commented 4 years ago

PrecipTable.ipynb:

No need to create the outputs directory twice.

ShaneMPutnam commented 4 years ago

EventsTable_Stratified.ipynb:

Looks much better!
Can remove: durations = [6, 12, 24, 96]
Could add more markdown to describe individual cells/for readability but looks good overall

ShaneMPutnam commented 4 years ago

This PR adds the ability to calculate runoff hydrographs using NOAA Atlas 14 or NRCS nested hyetographs. Results are saved to .xlxs, dss, and json files, closing #45. Resolves #50 by adding legends to plots in EventsTable_Stratified.ipynb. There are still open issues, including the need to update the readme and Docs for this repository but those can be addressed later.