search

Dewberry / ripple1d

Utilities for reuse of HEC-RAS models for NWM
https://ripple1d.readthedocs.io/en/latest/
MIT License
3 stars 0 forks source link

ripple_version logic #131

Closed ar-siddiqui closed 2 months ago

ar-siddiqui commented 2 months ago

In v0.4.0, ripple_version is no longer required in POST payloads, but when provided what does it do? The ripple_version should never be an input in the request payload, it doesn't make sense to take the version from the input request.

Also IMO it is better not to write ripple1d_version in rating curve DB and should be recorded in reach STAC Item.

Originally posted by @ar-siddiqui in https://github.com/Dewberry/ripple1d/issues/93#issuecomment-2299637471

mdeshotel commented 2 months ago

I'll remove ripple_version as an optional arg for all processes. I can remove ripple1d_version from the rating curve DB as well. The ripple1d_version should already be in the STAC items. Let me know if you are not seeing it.