Dewberry / ripple1d

Utilities for reuse of HEC-RAS models for NWM
https://ripple1d.readthedocs.io/en/latest/
MIT License
3 stars 0 forks source link

USGS DEM value hardcoded in `fim_lib.py` #138

Closed ar-siddiqui closed 2 months ago

ar-siddiqui commented 2 months ago

This silently fails the create_fim_lib request when using any DEM other than the default. There are no outputs in the fims folder. https://github.com/Dewberry/ripple1d/blob/9c9bf95e69b7f22f57884e49b2d8eff0d7ab0e68/ripple1d/ops/fim_lib.py#L61

This also highlights that tests need to be extended, if manual tests were performed for the S3 DEM feature add, this would have been caught.