This PR fixes 2 bugs associated with structures. 1) Lateral structures were not being excluded (they are not currently supported in ripple). 2) Structure river stationing weren't being updated correctly when two RAS reaches were combined.
These two bugs were causing the API to hang. While ripple1d should no longer hang for these two bugs, ripple1d could still hang for some other issue. This PR does NOT provide a timeout which might be ideal for future/similar bugs during production.
This PR also updates the api_tests to run all reaches in the Baxter Test model.
User/tester changes:
3 test scripts have been combined into one; i.e., api_tests_Baxter, api_test_MissFldwy, and api_test_PutuxentRiver have been merged into api_test.py
To execute the api tests the user/tester needs to call run_api_test.py which manages the test calls.
By default (providing no args) "run_api_tests.py" will run all test reaches for the Baxter test model and
"2930557" and "11906190" for the MissFldwy and PatuxentRiver test models, respectively.
Example 1 usage:
python tests/run_api_tests.py
Alternatively, you can specify the test model and reach id to run as args.
Example 2 usage:
python test/run_api_tests.py Baxter 2826228
Json files containing the results of the bulk test runs are produced but only if a test failed for the specific model-reach.
A summary results json is also produced which compiles the fails across all test models/reaches.
This PR fixes 2 bugs associated with structures. 1) Lateral structures were not being excluded (they are not currently supported in ripple). 2) Structure river stationing weren't being updated correctly when two RAS reaches were combined.
These two bugs were causing the API to hang. While ripple1d should no longer hang for these two bugs, ripple1d could still hang for some other issue. This PR does NOT provide a timeout which might be ideal for future/similar bugs during production.
This PR also updates the api_tests to run all reaches in the Baxter Test model.
User/tester changes:
3 test scripts have been combined into one; i.e., api_tests_Baxter, api_test_MissFldwy, and api_test_PutuxentRiver have been merged into api_test.py
To execute the api tests the user/tester needs to call run_api_test.py which manages the test calls.
By default (providing no args) "run_api_tests.py" will run all test reaches for the Baxter test model and "2930557" and "11906190" for the MissFldwy and PatuxentRiver test models, respectively. Example 1 usage: python tests/run_api_tests.py
Alternatively, you can specify the test model and reach id to run as args. Example 2 usage: python test/run_api_tests.py Baxter 2826228
Json files containing the results of the bulk test runs are produced but only if a test failed for the specific model-reach.
A summary results json is also produced which compiles the fails across all test models/reaches.
Fixes #130