Deweh / CyberCAT-SimpleGUI

A simplified offshoot of SirBitesalot's CyberCAT.
MIT License
233 stars 45 forks source link

Save button missing on Linux / Add Ctrl + S support #100

Open khionu opened 2 years ago

khionu commented 2 years ago

Steps to reproduce:

  1. Make Linux environment
    • VM is fine because you don't need to play the game, can copy the savee from Windows
  2. Create wine environment using protontweaks (for pure reproducibility, may not be essential)
  3. Right-click on CyberCAT executable and click "Launch using Protontricks Launcher" (or the equivalent for your DE)
  4. Give extra time to start because abstraction layers
  5. Try to save

Result: Save button doesn't exist Expected: Save button exists

Recommended solution: troubleshoot why the button fails to show on Linux Alternative solution: add Ctrl + S support to trigger the save function

image

terupyon commented 2 years ago

As per FAQ on nexusmods

Q. I don't have any "Save Changes" button. A: Open config.json in any text editor and change "SaveButtonPosition" to 1.

I did not have a config.json file, so grabbed it directly from repo. Save Changes showed directly under Quest Facts button. Tested on latest protonGE.

12 and #53 mentions it.

khionu commented 2 years ago

Thanks, will test later today

khionu commented 2 years ago

@terupyon what GE version were you using specifically? I switched to 7-31 and the save editor won't even start, had been using Proton 6

khionu commented 2 years ago

With Proton Experimental, the config.json edit doesn't work. Where did you put it and how did you launch it?

terupyon commented 2 years ago

@khionu Wine-GE-Proton7-29 (running standalone GOG version of Cyberpunk), think it's the same as GE-Proton7-35 release for Steam. Using the same prefix as Cyberpunk install, checking winetricks.log I see d3dcompiler_47 and mfc140, needed them for some mods, no idea if they change anything. config.json in the same directory as cybercat executable, using a simple wrapper script that exports WINEPREFIX and proton/bin PATH environment variables then launches the executable through wine. Should work perfectly fine through protontricks-launch, though. Here's what it looks like on my end: 2022-10-04-201845_974x544_scrot

khionu commented 2 years ago

I used the protontricks launcher, still looks identical to my first screenshot.

terupyon commented 2 years ago

Double check config.json, maybe a typo snuck in?

{
  "SaveButtonPosition":1,
  "EnablePSData":1
}

Other than that no idea. As a last resort you can try setting up a clean wineprefix with wineGE instead of protonGE, maybe it has something extra.

khionu commented 2 years ago

I could do a fresh prefix, but I have strong doubts that that would be the issue. Also, double checked, no typos

AlexNomadrg commented 2 years ago

I have the same issue. I tried running the editor via protontricks-launch --appid 1091500 CP2077SaveEditor.exe and editing config.json but that didn't help

khionu commented 2 years ago

I also didn't experience any change in behaviour with that fix, sorry for the delay in response

ParzivalWolfram commented 4 months ago

I can't launch at all under current Proton Experimental, but the save button does, in fact, currently show properly under stock Wine 9.11. Either this was fixed, or the issue is due to a regression in Proton.

image