Deweh / CyberCAT-SimpleGUI

A simplified offshoot of SirBitesalot's CyberCAT.
MIT License
233 stars 45 forks source link

Regression bug introduced from v0.08a -> v0.08a_r1 (Game/save version 1.11) #20

Closed spacesynth closed 3 years ago

spacesynth commented 3 years ago

grafik

1) Load any save 2) It crashes with error below in v0.08a_r1

System.ArgumentNullException: Value cannot be null. (Parameter 'source')
   at System.Linq.ThrowHelper.ThrowArgumentNullException(ExceptionArgument argument)
   at System.Linq.Enumerable.Select[TSource,TResult](IEnumerable`1 source, Func`2 selector)
   at CP2077SaveEditor.Form1.openSaveButton_Click(Object sender, EventArgs e)
   at System.Windows.Forms.Control.OnClick(EventArgs e)
   at CP2077SaveEditor.ModernButton.TextMouseUp(Object sender, EventArgs e)
   at System.Windows.Forms.Control.OnMouseUp(MouseEventArgs e)
   at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.Label.WndProc(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, WM msg, IntPtr wparam, IntPtr lparam)

cut long list of assembly DLLs

v0.08a (NON-R1) works!

Proof: grafik

Deweh commented 3 years ago

Could you link your save? I can't reproduce this issue with any of my 1.11 saves.

Deweh commented 3 years ago

I realized that there's only one LINQ Select statement in openSaveButton_Click. Please try 54edf5ced3186fb392529222f8efc94cf7a1625c and let me know if it resolves the issue.

spacesynth commented 3 years ago

ManualSave-1.zip

testing soon but yes my save

Edit: I have no buildchain ready on my work machine and cannot test.

Deweh commented 3 years ago

No worries, I tested with your save and 54ef5bcf078be72a4917c46b5eb11e93b649dac7 cleanly resolves the issue. The fix will be included in v0.08a_r2.

spacesynth commented 3 years ago

I love your tool and it's frequent updates, many thanks for the fast help and verification!