Proposal/RFC: Quick delete items from inventory view

Deweh / CyberCAT-SimpleGUI

A simplified offshoot of SirBitesalot's CyberCAT.

MIT License

233 stars 45 forks source link

Proposal/RFC: Quick delete items from inventory view #6

Closed adupuis2 closed 3 years ago

adupuis2 commented 3 years ago

Tap the Delete key after selecting a Simple item row to set its Quantity to 0.
Only works for Simple items currently.
Simple item rows now have a different color.

Deweh commented 3 years ago

Just two notes:

Calling RefreshInventory without setting activeItemEdit will cause it to reset to the top. This can be problematic for larger inventories. I would set activeItemEdit before calling RefreshInventory then unset, or directly call inventoryListView.EnsureVisible (023f9995fc6533549c8e5c8393c1ea9dd624d595 fixes this issue.)
A color for Simple items that is more neutral to the white/grey theme is needed.

adupuis2 commented 3 years ago

A color for Simple items that is more neutral to the white/grey theme is needed.

Thanks for the upstream change regarding inventory refresh issue. Still figuring out C# and whatever this designer stuff is called (WPF?).

~I'm selecting a color that has a contrast ratio of 3 using this tool. The resulting color: Is this acceptable?~

Nevermind. Just stealing the color from elsewhere in the interface. 😅

Deweh commented 3 years ago

No worries. CyberCAT-SimpleGUI uses WinForms, which is an older but more reliable alternative to WPF.

It think it may be best to just scrap the alternating colors, it doesn't look too great with the limitations of a ListView. I've added the Simple/Modable type to the "Type" column (147d109d2cce695502cf340e2f08a7c55436866a) so that that info can still be seen at a glance.

Edit: This also has the added benefit of being able to use the inventory's column search feature to view only Simple or Modable items. For example "type:[m]" would show only Modable items.

adupuis2 commented 3 years ago

Alternate color removed & PR rebased. :D