DexPatcher / dexpatcher-gradle

Modify Android applications at source-level in Android Studio
https://dexpatcher.github.io/
GNU General Public License v3.0
84 stars 17 forks source link

Not able to download v2.1.0 from maven repo #32

Open Surendrajat opened 4 years ago

Surendrajat commented 4 years ago

Was wondering if dexpatcher repo has been updated.

A side question, will the patches continue to work on if I want to use the latest v2.1.1+ given they're in maven repo as well? I see the release notes say apk library won't work.

Lanchon commented 4 years ago

dxp-gradle is published on the gradle plugin portal https://plugins.gradle.org/search?term=dexpatcher

2.1.0 has been published there but it took some time to be approved now it is

the rest of the stuff is in my own repo, and it is up to date

dxp-gradle 2.1.x versions will be on the portal once finalized

Surendrajat commented 4 years ago

Not sure why but I had to change it to

dependencies {
    classpath "gradle.plugin.com.github.lanchon.dexpatcher:dexpatcher-gradle:2.1.0"
}

to make it work.

Lanchon commented 4 years ago

does it even work? it shouldn't! it seems u r not checking out the right tag

for dxp-gradle v2.1.0 you need to checkout samples v2.1.0

i recommend u use git gui and gitk --all if u r in doubt.

Surendrajat commented 4 years ago

Screenshot from 2020-06-24 11-53-58

Yes. I did this. Somehow it keeps throwing:

A problem occurred configuring root project 'patched-app'.
> Could not resolve all artifacts for configuration ':classpath'.
   > Could not find com.github.lanchon.dexpatcher:dexpatcher-gradle:2.1.0.
     Searched in the following locations:
       - https://dl.google.com/dl/android/maven2/com/github/lanchon/dexpatcher/dexpatcher-gradle/2.1.0/dexpatcher-gradle-2.1.0.pom
       - https://dl.google.com/dl/android/maven2/com/github/lanchon/dexpatcher/dexpatcher-gradle/2.1.0/dexpatcher-gradle-2.1.0.jar
       - https://jcenter.bintray.com/com/github/lanchon/dexpatcher/dexpatcher-gradle/2.1.0/dexpatcher-gradle-2.1.0.pom
       - https://jcenter.bintray.com/com/github/lanchon/dexpatcher/dexpatcher-gradle/2.1.0/dexpatcher-gradle-2.1.0.jar
       - https://plugins.gradle.org/m2/com/github/lanchon/dexpatcher/dexpatcher-gradle/2.1.0/dexpatcher-gradle-2.1.0.pom
     Required by:
         project :

but works if I use classpath "gradle.plugin.com.github.lanchon.dexpatcher:dexpatcher-gradle:2.1.0". Weird

Lanchon commented 4 years ago

oh sorry! i misunderstood! yeah the gradle people prepended gradle.plugin. i'll remove the build and talk to them.

Lanchon commented 4 years ago

FYI...

https://github.com/iBotPeaches/Apktool/issues/2369

Surendrajat commented 4 years ago

Yeah. Saw that in the morning as I'm following that project too :) Cool and quick response. Hopefully, the next version is usable with the latest plugin for now at least.

Lanchon commented 4 years ago

so the gradle plugin portal publishing plugin, the one you MUST run locally on your PC in order to publish a plugin to the gradle plugin portal, is sneakily closed source and proprietary. i say sneakily because gradle presents themselves to be an open source solution and their docs link to the plugin. there is (or that may have been fixed in the last couple of days) absolutely no mention of the closed source nature of the publish plugin or its license anywhere. in order to realize it is closed-source you must go through all published sources and rule out it not being there -quite a job- and then ask gradle employees, and then maybe they'll tell you it is not free software.

so i was tricked into running proprietary software on my machines. horrible.

of course i am not using the portal -which misbehaved and mispublished my stuff anyway- again, so the newer plugins will need to find another home. also i reported and complained about this situation, so i got banned from the gradle org in github, lol.

so now i'm trying to get gradle to delete my stuff from their servers, but they are not replying to my emails, although i'm writing to the right address for that. and i can't open support tickets because, guess, yep they are hosted on github, they same place where they so hastily ban dissence.

that's why you haven't seen any progress these last weeks. needless to say, i'll avoid the gradle team and its products as much as possible in the future.

Surendrajat commented 4 years ago

That's very unfortunate and deceiving. However, this is a trend in all profit-making companies to brand their semi-OpenSource software as OpenSource these days.

But have you explored the GitHub packages option for just this?

Lanchon commented 4 years ago

But have you explored the GitHub packages option for just this?

thanks!

interesting... i think i might extend my own repo with the plugins. the downside is that source will not be in the repo. the upside is that i can delete packages as i see fit. this helps especially with the first repo publications, which might have problems.

1LineAtaTime commented 4 years ago

yeah, I had to change the following things to get the patched-app to compile:

dependencies { // Android Gradle plugins: classpath 'com.android.tools.build:gradle:3.4.3' }

dependencies { // DexPatcher Gradle plugins: classpath 'gradle.plugin.io.github.dexpatcher.dexpatcher-gradle:dexpatcher-gradle:2.1.0' }

apply plugin: 'io.github.dexpatcher.patched-application'

Lanchon commented 4 years ago

ive requested gradle more than 2 weeks ago that they delete that plugin. please dont use it. it will stop working and the presence of usage statistics make it more difficult have gradle finally delete the thing. if u must use this unofficial 2.1.0, then download it and use it locally.

1LineAtaTime commented 4 years ago

Got it. Thanks. I believe I had downloaded the latest version with 2.1.3 (latest commit on Jun 23) --> 'com.github.lanchon.dexpatcher:dexpatcher-gradle:2.1.3' It was giving me errors with not finding different repositories, so I had to change it.

Lanchon commented 4 years ago

checkout the V2.0.0 tag from git or download the tag's zip offered by github.

Surendrajat commented 3 years ago

@Lanchon Just fyi... apktool v2.5.0 got released :)

Lanchon commented 3 years ago

i added it to my repo a day ago.

Surendrajat commented 3 years ago

Hi @Lanchon. I was wondering if you could release the latest version somewhere. I'm having some issues(like this during manifest merge) with the old gradle plugin.