search

Dexels / navajo

Navajo Service-oriented Applications
GNU Affero General Public License v3.0
9 stars 5 forks source link

fixes #580: Proper support for locale header in function GetValidationDescription #581

Closed roelofkemp closed 3 years ago

roelofkemp commented 3 years ago

see: https://github.com/Dexels/navajo/issues/580

kharybdys commented 3 years ago

I would prefer to refactor GetRequestLocale at the same time - split the main logic off of the evaluate, and make it static. So GetValidationDescription can then call the new static function in GetRequestLocale, passing its own Access object (I would pass that) Although the static funciton in GetRequestLocale might even belong somewhere else (probably on Access)

kharybdys commented 3 years ago

After discussion with Roelof it turns out that Lookup is also involved which exists in enterprise, not navajo, and several other factors which makes the whole required refactoring a bit too big for right now. So I approve the current change.

ghost commented 3 years ago

Approved based on Ɛ knowledge.