Closed roelofkemp closed 3 years ago
I would prefer to refactor GetRequestLocale at the same time - split the main logic off of the evaluate, and make it static. So GetValidationDescription can then call the new static function in GetRequestLocale, passing its own Access object (I would pass that) Although the static funciton in GetRequestLocale might even belong somewhere else (probably on Access)
After discussion with Roelof it turns out that Lookup is also involved which exists in enterprise, not navajo, and several other factors which makes the whole required refactoring a bit too big for right now. So I approve the current change.
Approved based on Ɛ knowledge.
see: https://github.com/Dexels/navajo/issues/580