steer(l,r) use self.speed instead of self.NO_LIMIT_SPEED

DexterInd / GoPiGo3

The GoPiGo3 is a Raspberry Pi Robot!

https://gopigo.io

Other

98 stars 85 forks source link

steer(l,r) use self.speed instead of self.NO_LIMIT_SPEED #289

Closed slowrunner closed 2 years ago

slowrunner commented 3 years ago

I have confirmed this change corrects steer(l,r) to work as expected using test program: https://github.com/slowrunner/Carl/blob/master/systests/motors/easy_steer.py

CleoQc commented 3 years ago

Sorry I meant to leave a message here for a while.

There's a reason that we couldn't go with this change, but I can't remember why. That's the reason I haven't merged yet. I will need lots of testing in lots of situations.

slowrunner commented 3 years ago

no problem :)

CleoQc commented 2 years ago

This PR's spirit lives in https://github.com/DexterInd/GoPiGo3/pull/303 In essence it's the exact same fix. Thank you for your contribution!