search

Dexterleow / ga-account-html-page

Other
0 stars 0 forks source link

Code Review #1

Open davified opened 8 years ago

davified commented 8 years ago

Nice work Dexter! Based on your code for both pieces of homework, I think you've understood html element tags quite well :-)

Just a comment on indentation: You should properly indent your code by using the "tab" keyboard button. This will make code easier to read, and people will see you as a better programmer if you indent code right :-) For instance, I would indent your ga-account-html-page assignment as such:

<html lang ="en-US">

  <head>
    <meta charset="utf-8">
    <title>General Assembly Account Creation</title>
  </head>
  <body>
    <img alt="general assembly logo" src="...">
    <h1>General Assembly Account Creation</h1>
    <h4>Welcome to the General Assembly. General Assembly is a global institution training people all over the world in today's top technologies.</h4>

    <h4>Please fill out the information below to create your General Assembly account. Let us know what city you're in and what course you're taking. This list is for all students. Please tell us what city you're in and whether you're taking the Immersive User Experience (UX) course or the Immersive Web Development course.</h4>

    <div>
      City:
      <select>
        <option value="seattle">Seattle</option>
        <option value="hongkong">Hong Kong</option>
        <option value="london">London</option>
        <option value="losangeles">Los Angeles</option>
        <option value="newyork">New York</option>
        <option value="portland">Portland</option>
        <option value="sanfrancisco">San Francisco</option>
        <option value="singapore">Singapore</option>
      </select>
    </div>
    <br>

    <form>
    Course:
    <input type="radio" name="gender" value="male" checked>UX
    <input type="radio" name="gender" value="male" checked>Web Dev
    Name <input type="text" name="firstname"><br>
    Email<input type="text" name="lastname"><br>
    Password<input type="text" name="lastname">
    <input name="name" type="checkbox" checked="checked"> Yes, subscribe me to the General Assembly student newsletter<br>
  </form>
</body>
</html>

Otherwise, really good job. Keep it up! :-)

Dexterleow commented 8 years ago

Hey David,

Thanks! I c. Noted on the indentation, will adopt it and strive to be a better prgrammer.

Once again, thanks for all the constant help! :)

Cheers, Dexter

On Tuesday, 16 August 2016, David Tan notifications@github.com wrote:

Nice work Dexter! Based on your code for both pieces of homework, I think you've understood html element tags quite well :-)

Just a comment on indentation: You should properly indent your code by using the "tab" keyboard button. This will make code easier to read, and people will see you as a better programmer if you indent code right :-) For instance, I would indent your ga-account-html-page assignment as such:

General Assembly Account Creation general assembly logo

General Assembly Account Creation

Welcome to the General Assembly. General Assembly is a global institution training people all over the world in today's top technologies.

```

Please fill out the information below to create your General Assembly account. Let us know what city you're in and what course you're taking. This list is for all students. Please tell us what city you're in and whether you're taking the Immersive User Experience (UX) course or the Immersive Web Development course.

City:

Course: UX Web Dev Name
Email
Password Yes, subscribe me to the General Assembly student newsletter
```

Otherwise, really good job. Keep it up! :-)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Dexterleow/ga-account-html-page/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/AOoh8mKvUKsLn2IyamVmLFlXkWVHaOqBks5qgSsbgaJpZM4Jk_gq .