search

Dexus / pem

Create private keys and certificates with node.js
Other
570 stars 129 forks source link

use DEBUG flag instead of CI #358

Open simon-q opened 1 year ago

simon-q commented 1 year ago

CI is set to true in CI/CD tools such as Bitbucket pipelines. That results in excessive debug log if pem library is used in scripts that run in CI/CD of other projects, e.g. when pem library is used in tests that are running in a Bitbucket pipeline. It would be therefore better to use a different flag than CI to control when debug logs are produced. This PR suggests DEBUG flag.

cernytomas commented 1 year ago

Hi @Dexus, could you please have a look?

Dexus commented 1 year ago

If you want to change it, the GitHub workflow should be considered as well. If the change is made, I can accept it.

cernytomas commented 1 year ago

If you want to change it, the GitHub workflow should be considered as well. If the change is made, I can accept it.

I made requested changes https://github.com/Dexus/pem/pull/373