Deyda / NeverRed

NeverRed's focus is to provide a simple solution to keep standard software up to date without having to package it or search and compare versions on vendor sites. https://www.deyda.net/index.php/en/neverred/
33 stars 5 forks source link

Citrix Workspace App version comparison #82

Closed jpmoock closed 4 months ago

jpmoock commented 4 months ago

In the current version of the script (2.10.32), the downloaded version of the LTSR app is returned as 24.02.0.172, while the installed version is returned as 24.2.0.172. This results in the Citrix Workspace LTSR app being reinstalled unecessarily.

I believe this is happening because of a typo in the code that pads the version string with leading zeroes for the $WSA variable in the Citrix WorkspaceApp section.

The $Version variable calculation in the Download Citrix WorkspaceApp section contains the following code, which functions correctly: $CurrentWSAStringLast = ([regex]::Matches($CurrentWSASplit[3], "." )).count

The $WSA variable calculation in the Download Citrix WorkspaceApp section appears to have a typo in the $CurrentWSAStringLast variable (it should use $CurrentWSASplit[3] instead of $CurrentWSASplit[1]): $CurrentWSAStringLast = ([regex]::Matches($CurrentWSASplit[1], "." )).count

Deyda commented 4 months ago

Correction in Version 2.10.33