search

Dezenix / android-frontend-java

Code Snippets of highly interactive Android App Templates in Java that can be implemented in any Android Application.
MIT License
6 stars 8 forks source link

Added Login and Register Screens #7

Closed Kajal13081 closed 2 years ago

Kajal13081 commented 2 years ago

Fixes #4

@GovindSingh9447 Sir review this please.

Kajal13081 commented 2 years ago

@Ovenoboyo I updated the changes. Please review it once.

Kajal13081 commented 2 years ago

Everything looks perfect. Only the strings need to be changes and ill approve this

What changes? Can you elaborate please

Ovenoboyo commented 2 years ago

Everything looks perfect. Only the strings need to be changes and ill approve this

What changes? Can you elaborate please

In the previous review I had specified "unecessary string". That part was only meant for the "todo" string. I think due to some misunderstanding you have removed all strings from strings.xml and their usages too. So you'll just have to revert that part

Kajal13081 commented 2 years ago

Everything looks perfect. Only the strings need to be changes and ill approve this

What changes? Can you elaborate please

In the previous review I had specified "unecessary string". That part was only meant for the "todo" string. I think due to some misunderstanding you have removed all strings from strings.xml and their usages too. So you'll just have to revert that part

Okay

Kajal13081 commented 2 years ago

@Ovenoboyo done. Please review it.

Kajal13081 commented 2 years ago

image I have to commit only this folder na? @Ovenoboyo

Kajal13081 commented 2 years ago

I have committed. Please do mention which files I need to delete more. I created a new PR.

Ovenoboyo commented 2 years ago

Moved to #9