Dhahi374 / likwid

Automatically exported from code.google.com/p/likwid
GNU General Public License v3.0
0 stars 0 forks source link

Typo in perfmon_haswell_events.txt (IDQ_ALL_MITE_CYCLES_4_UOPS/IDQ_ALL_MITE_CYCLES_ANY_UOPS) #168

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
There looks to be a copy and paste error in 
likwid-3.1.2/src/include/perfmon_haswell_events.txt. 

EVENT_IDQ               0x79   PMC
UMASK_IDQ_EMPTY         0x02
UMASK_IDQ_MITE_UOPS     0x04
UMASK_IDQ_DSB_UOPS      0x08
UMASK_IDQ_MS_DSB_UOPS   0x10
UMASK_IDQ_MS_MITE_UOPS  0x20
UMASK_IDQ_MS_UOPS       0x30
UMASK_IDQ_ALL_DSB_CYCLES_ANY_UOPS      0x18 0x00 0x01
UMASK_IDQ_ALL_DSB_CYCLES_4_UOPS        0x18 0x00 0x04
UMASK_IDQ_ALL_MITE_CYCLES_4_UOPS       0x24 0x00 0x01
UMASK_IDQ_ALL_MITE_CYCLES_4_UOPS       0x24 0x00 0x04
UMASK_IDQ_ALL_MITE_ALL_UOPS       0x3C

The name "UMASK_IDQ_ALL_MITE_CYCLES_4_UOPS" is repeated twice.  Per Intel Vol 
3B 
(http://www.intel.com/content/dam/www/public/us/en/documents/manuals/64-ia-32-ar
chitectures-software-developer-vol-3b-part-2-manual.pdf)  the first line (with 
CMASK=1) should instead read "UMASK_IDQ_ALL_MITE_CYCLES_ANY_UOPS".  

For consistency with the Intel manual, it looks like the last line should also 
be renamed to "UMASK_IDQ_MITE_ALL_UOPS" (dropping the _ALL) unless this was a 
conscious choice.  Although it's possible that the manual has a typo too, as 
the name "IDQ_ALL_UOPS" would match their description better.  

Original issue reported on code.google.com by n...@verse.com on 6 Oct 2014 at 4:28

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r248.

Original comment by Thomas.R...@googlemail.com on 6 Oct 2014 at 8:50