DhanaGitHub / maven-replacer-plugin

Automatically exported from code.google.com/p/maven-replacer-plugin
0 stars 0 forks source link

Tokens starting with # no longer accepted in tokenValueMap #39

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. use a tokenValueMap with a token that starts with #
2. mvn replacer:replace

What is the expected output? What do you see instead?

I'm expecting the token to be replaced.

I'm probably one of the few people who has tokens that start with a # and hence 
got bitten by the solution issue 36.  There was a suggestion there to be able 
to toggle comments on and off...?

Something else to note is that tokens starting with # still work if you're 
declaring the tokens in the pom, which makes it inconsistent with the way the 
tokens are read in from tokenValueMap.

What version of the product are you using? On what operating system?

1.3.4 on Linux.

Please provide any additional information below.

Original issue reported on code.google.com by myro...@gmail.com on 15 Nov 2010 at 9:32

GoogleCodeExporter commented 9 years ago
Hi myronwu,

Comments are enabled by default in the tokenValueMap. If your token starts with 
an '#' then you need to use <commentsEnabled>false</commentsEnabled>.

Sorry, I must have forgotten to update the UsageGuide and will do so now.

Steven

Original comment by baker.st...@gmail.com on 15 Nov 2010 at 11:15

GoogleCodeExporter commented 9 years ago
Oh, I was trying <comments-enabled>true</comments-enabled> and hadn't looked at 
the code...

Original comment by myro...@gmail.com on 15 Nov 2010 at 11:17

GoogleCodeExporter commented 9 years ago
My mistake, I should have updated the UsageGuide.

Is this Issue okay to close?

Original comment by baker.st...@gmail.com on 15 Nov 2010 at 11:19

GoogleCodeExporter commented 9 years ago
Yep

Original comment by myro...@gmail.com on 15 Nov 2010 at 11:21

GoogleCodeExporter commented 9 years ago

Original comment by baker.st...@gmail.com on 15 Nov 2010 at 11:22