DhanaGitHub / maven-replacer-plugin

Automatically exported from code.google.com/p/maven-replacer-plugin
0 stars 0 forks source link

Inheritance of ignoreMissingFile #41

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
It seems that IgnoreMissingFile is not properly inherited to child poms in a 
multi-module project. 
If I execute mvn in the child pom, the missing file is ignored (configuration 
is taken from the parent). If I execute mvn on the parent pom, build breaks on 
the child pom because of the missing file.

What steps will reproduce the problem?
1. Untar the provided example
2. Run mvn generate-sources on the child pom and notice that the missing file 
is ignored correctly.
3. Run mvn generate-sources on the parent pom and notice that the build breaks 
when processing the child pom... puzzling

What is the expected output? What do you see instead?
When executing the parent pom, the build should work correctly and the missing 
file in the child module shouldn't cause the build to fail

What version of the product are you using? On what operating system?
I'm using v1.3.4 of the plugin
Reproduced with 
-------------------------------------------------
Apache Maven 2.2.1 (r801777; 2009-08-06 21:16:01+0200)
Java version: 1.6.0_22
Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home
Default locale: es_ES, platform encoding: MacRoman
OS name: "mac os x" version: "10.6.5" arch: "x86_64" Family: "mac"
-------------------------------------------------
and
-------------------------------------------------
Apache Maven 2.2.1 (rdebian-1)
Java version: 1.6.0_22
Java home: /usr/lib/jvm/java-6-sun-1.6.0.22/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux" version: "2.6.32-26-generic-pae" arch: "i386" Family: "unix"
-------------------------------------------------

Original issue reported on code.google.com by pragone@gmail.com on 26 Nov 2010 at 9:59

Attachments:

GoogleCodeExporter commented 9 years ago
I was able to find the problem. When FileUtils.checkFileExists() method is 
called, the filename that's passed is always relative to the working dir, so, 
if the file exists in the parent pom. It's considered to exist for all child... 
:)

I'm attaching a patch that solved the issue for me.

This is kind of an urgent issue because I won't have access in the Continuous 
Integration environment to deploy the patched version of the plugin, so if you 
think the patch is OK, I'd appreciate if you can release the fix soon.

Thanks
Paolo

Original comment by pragone@gmail.com on 26 Nov 2010 at 10:31

Attachments:

GoogleCodeExporter commented 9 years ago
I'll get to work on this as a priority for you and let you know.

Original comment by baker.st...@gmail.com on 27 Nov 2010 at 7:00

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Fixed in version 1.3.5.

Original comment by baker.st...@gmail.com on 27 Nov 2010 at 5:34

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Wow.... that was very vast

This way, it really pays of to be a good Open Source citizen and contribute 
back :)

Thanks a lot for the great effort

Cheers
Paolo

Original comment by pragone@gmail.com on 27 Nov 2010 at 7:30

GoogleCodeExporter commented 9 years ago
Just issue clean up.

Original comment by baker.st...@gmail.com on 17 Sep 2012 at 12:43