search

DhanushNehru / alien-defender-game

An Alien Space Themed Browser Game
https://alien-defender-game.netlify.app/
Apache License 2.0
2 stars 7 forks source link

Code of conduct.md #10

Closed Brijeshthummar02 closed 3 days ago

Brijeshthummar02 commented 3 days ago

issue #3

netlify[bot] commented 3 days ago

Deploy Preview for alien-defender-game ready!

Name Link
Latest commit b616c841a144170013b7a01c00a91e95e08cc710
Latest deploy log https://app.netlify.com/sites/alien-defender-game/deploys/66f79562089fac000854f2ef
Deploy Preview https://deploy-preview-10--alien-defender-game.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Brijeshthummar02 commented 3 days ago

Share feedback for current pull request, and if it's fine than please do me a favor merge it in oct 1-2 when hacktoberfest starts so that i can claim merge request.

shubhansu-kr commented 3 days ago

@Brijeshthummar02 This is not the right way. I appreciate your enthusiasm and passion to contribute to open source, but you were not assigned this issue in the first place. Please request assignee on the issue you want to work on and then create a PR. Please avoid creating conflicts.

shubhansu-kr commented 3 days ago

Additionally, You are required to create PR between 1st oct to 30st oct to get accepted for hactoberfest. If you create it today and merge it later, it won't work.

Brijeshthummar02 commented 3 days ago

@shubhansu-kr i totally agree on that, but you commented 3 days ago and still not created a pr, so i thought why not i. as of now i've created a pr so you can work on some other issues.

shubhansu-kr commented 3 days ago

@shubhansu-kr i totally agree on that, but you commented 3 days ago and still not created a pr, so i thought why not i. as of now i've created a pr so you can work on some other issues.

Your "why not" should be answered by "Because it's not assigned to me". I hope that helps.

Brijeshthummar02 commented 3 days ago

You taking it personally.

shubhansu-kr commented 3 days ago

I have my PR ready, but didn't create one because it should adhere to the hactoberfest timelines. This PR you created is invalid and should be marked accordingly. However that decision is upto the project maintainer to make.

Thanks.

shubhansu-kr commented 3 days ago

You taking it personally.

I am following the guidelines.

DhanushNehru commented 3 days ago

Hi @Brijeshthummar02 please check issue section first before raising a PR.

This issue is already assigned to @shubhansu-kr

But @shubhansu-kr it's over to you to decide whether I should close this PR or Merge it ?

shubhansu-kr commented 3 days ago

@DhanushNehru, appreciate your guidance. I won't have had any issue merging this PR, however i notice, @Brijeshthummar02 has done similar thing with other issues as well as you can see here #2 . This does not foster collaboration and leads to waste of community efforts given i have my branch ready, just waiting for hactoberfest to start.

I leave this decision upto you, it's fine both ways if he stops doing this with other issues as well.

Thanks.

Brijeshthummar02 commented 3 days ago

@shubhansu-kr i got it, won't be doing it again.

DhanushNehru commented 3 days ago

Closing this PR as the issue is already assigned to @shubhansu-kr